Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PUI] Fix for hovering in parameteric part table #7933

Merged
merged 2 commits into from
Aug 20, 2024
Merged

[PUI] Fix for hovering in parameteric part table #7933

merged 2 commits into from
Aug 20, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Visual glitches are now gone
  • Improved rendering / memoizing of components

@SchrodingersGat
Fix for hovering in parameteric part table
4fa86c1 
- Visual glitches are now gone
@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface labels Aug 20, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Aug 20, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 20, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 47898c5
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c3f828f741e1000801302c
😎 Deploy Preview https://deploy-preview-7933--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 8 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.47%. Comparing base (6591286) to head (47898c5).
Report is 4 commits behind head on master.

Files Patch % Lines
...c/frontend/src/tables/part/ParametricPartTable.tsx 0.00% 27 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7933      +/-   ##
==========================================
+ Coverage   83.45%   83.47%   +0.02%     
==========================================
  Files        1130     1130              
  Lines       50382    50399      +17     
  Branches     1745     1750       +5     
==========================================
+ Hits        42045    42070      +25     
+ Misses       7887     7886       -1     
+ Partials      450      443       -7
Flag Coverage Δ
pui 65.25% <27.02%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit dbe12c2 into inventree:master Aug 20, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the param-hover-fix branch August 20, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat